-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(control-panel): support deploying large station WASM #364
base: main
Are you sure you want to change the base?
Conversation
// The canister modules required for the control panel. | ||
type UploadCanisterModulesInput = record { | ||
// The upgrader wasm module to use for the station canister. | ||
upgrader_wasm_module : opt blob; | ||
// The station wasm module to use. | ||
station_wasm_module : opt blob; | ||
// Optional extra chunks of the station canister wasm module. | ||
station_wasm_module_extra_chunks : opt opt WasmModuleExtraChunks; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe i've already asked before, but why the opt opt
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's confusing...
The outer opt stands for "do I want to override this field or not". The inner opt stands for "is this WASM chunked or not".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds support for deploying large station WASM into the control panel canister.